Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow data parameter to be optional for presence#enter and channell#subscribe (2) #50

Merged
merged 8 commits into from
May 12, 2015
Merged

Allow data parameter to be optional for presence#enter and channell#subscribe (2) #50

merged 8 commits into from
May 12, 2015

Conversation

SimonWoolf
Copy link
Member

paddybyers added a commit that referenced this pull request May 12, 2015
@paddybyers
Merge pull request #50 from ably/enter-no-data-2
7a4c005 
Allow data parameter to be optional for presence#enter and channell#subscribe (2)
@paddybyers paddybyers merged commit 7a4c005 into master May 12, 2015
@paddybyers
Copy link
Member

Thanks

@paddybyers paddybyers deleted the enter-no-data-2 branch May 12, 2015 10:19
@SimonWoolf
Copy link
Member Author

aaand just saw this failed ci, I'll just have a quick look at that

@SimonWoolf SimonWoolf mentioned this pull request May 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Presence#enterClient errors if not supplied with a data param
2 participants
@SimonWoolf @paddybyers